Official Everybody Edits Forums

Do you think I could just leave this part blank and it'd be okay? We're just going to replace the whole thing with a header image anyway, right?

You are not logged in.

#1 2017-11-22 15:59:24

TaskManager
Formerly maxi123
From: i really should update this
Joined: 2015-03-01
Posts: 9,457

the quote button and img tags are borked

try to quote this post for example and look at the IMG tags in the quoted message


i8SwC8p.png
signature by HG, profile picture by bluecloud, thank!!
previous signature by drstereos

Offline

Wooted by:

#2 2017-11-22 17:15:18

Different55
Forum Admin
Joined: 2015-02-07
Posts: 16,572

Re: the quote button and img tags are borked

Ha that's weird.

I get why it's happening but can't do anything to fix it for a good few hours.


"Sometimes failing a leap of faith is better than inching forward"
- ShinsukeIto

Offline

#3 2017-11-23 02:09:00

Different55
Forum Admin
Joined: 2015-02-07
Posts: 16,572

Re: the quote button and img tags are borked

Scratch that, accidentally left my laptop back at home and my desktop is ignoring me, can't access the server without either. Will hopefully be able to get that all fixed up in a few days when I get back home.


"Sometimes failing a leap of faith is better than inching forward"
- ShinsukeIto

Offline

Wooted by:

#4 2017-11-23 02:10:17

TaskManager
Formerly maxi123
From: i really should update this
Joined: 2015-03-01
Posts: 9,457

Re: the quote button and img tags are borked

different go home


i8SwC8p.png
signature by HG, profile picture by bluecloud, thank!!
previous signature by drstereos

Offline

#5 2017-11-23 11:36:18

Gosha
Member
From: Russia
Joined: 2015-03-15
Posts: 6,202

Re: the quote button and img tags are borked

go different home

Offline

Wooted by:

#6 2017-11-23 15:25:36

hummerz5
Member
From: wait I'm not a secret mod huh
Joined: 2015-08-10
Posts: 5,852

Re: the quote button and img tags are borked

who says you can't go home?

can you also explain what went wrong with our img tags here? t hanks

Offline

#7 2017-11-23 15:33:25

peace
Member
From: admin land
Joined: 2015-08-10
Posts: 9,226

Re: the quote button and img tags are borked

hummerz5 wrote:

who says you can't go home?

can you also explain what went wrong with our img tags here? t hanks

whats the point? noneoene can fix cuz only diff can acces the sever


peace.png

thanks hg for making this much better and ty for my avatar aswell

Offline

#8 2017-11-23 17:50:51

Xfrogman43
Member
From: need to find a new home
Joined: 2015-02-15
Posts: 4,174

Re: the quote button and img tags are borked

hummerz5 wrote:

who says you can't go home?

can you also explain what went wrong with our img tags here? t hanks

it doesnt quote

[img]

for some reason
4lJKuzo.png
check out the post he linked


zsbu6Xm.png thanks zoey aaaaaaaaaaaand thanks latif for the avatar

Offline

#9 2017-11-23 22:39:22

Different55
Forum Admin
Joined: 2015-02-07
Posts: 16,572

Re: the quote button and img tags are borked

hummerz5 wrote:

who says you can't go home?

can you also explain what went wrong with our img tags here? t hanks

Forum tries to strip image tags from quoted text. For some reason in that post it removes the first opening tag and the last closing tag and calls it good. I'm guessing an overly greedy regex or something?


"Sometimes failing a leap of faith is better than inching forward"
- ShinsukeIto

Offline

Wooted by:

#10 2017-12-02 16:31:09

Different55
Forum Admin
Joined: 2015-02-07
Posts: 16,572

Re: the quote button and img tags are borked

Right right

nearly forgot about this one

merged with maxi's topic


"Sometimes failing a leap of faith is better than inching forward"
- ShinsukeIto

Offline

#11 2017-12-02 17:08:11

Different55
Forum Admin
Joined: 2015-02-07
Posts: 16,572

Re: the quote button and img tags are borked

Somewhat fixed.

It was not an overly greedy regex, The regex for both the quick quote link (broken) and the dedicated quote page (working) was 100% identical. it was a bug in the regex itself on both pages. But it was a bug in the quick quote code that brought it out.

Whoever wrote the quick quote code escaped the quoted message (which messed with all new lines and special characters) before stripping out the image tags. Turns out the code that strips out image tags *hates* escaped new lines (or actually any non-whitespace text at all) directly in between its img tags. So you can actually still trigger the bug just by inserting your own fake escaped new lines in there:

[img]https://forums.everybodyedits.com/img/smilies/smile.png[/img]\n[img]https://forums.everybodyedits.com/img/smilies/sad.png[/img]

Or other text:

[img]https://forums.everybodyedits.com/img/smilies/smile.png[/img]test[img]https://forums.everybodyedits.com/img/smilies/sad.png[/img]

and it ends up breaking the quote code in the same way, and it works across both the quick quote link and the full quote page.

This is fixed, too, somewhat. It causes some issues of its own, but no new issues.


"Sometimes failing a leap of faith is better than inching forward"
- ShinsukeIto

Offline

Wooted by: (3)
Different551512230891684968

Board footer

Powered by FluxBB

[ Started around 1711690287.2162 - Generated in 0.046 seconds, 12 queries executed - Memory usage: 1.52 MiB (Peak: 1.69 MiB) ]