Official Everybody Edits Forums

TaskManager

Formerly maxi123

From: i really should update this

Joined: 2015-03-01

Posts: 9,465

the quote button and img tags are borked

try to quote this post for example and look at the IMG tags in the quoted message

---

signature by HG, profile picture by bluecloud, thank!!
previous signature by drstereos

Different55

Forum Admin

Joined: 2015-02-07

Posts: 16,575

Re: the quote button and img tags are borked

Ha that's weird.

I get why it's happening but can't do anything to fix it for a good few hours.

---

"Sometimes failing a leap of faith is better than inching forward"
- ShinsukeIto

Different55

Forum Admin

Joined: 2015-02-07

Posts: 16,575

Re: the quote button and img tags are borked

Scratch that, accidentally left my laptop back at home and my desktop is ignoring me, can't access the server without either. Will hopefully be able to get that all fixed up in a few days when I get back home.

---

"Sometimes failing a leap of faith is better than inching forward"
- ShinsukeIto

TaskManager

Formerly maxi123

From: i really should update this

Joined: 2015-03-01

Posts: 9,465

Re: the quote button and img tags are borked

different go home

---

signature by HG, profile picture by bluecloud, thank!!
previous signature by drstereos

Gosha

Member

From: Russia

Joined: 2015-03-15

Posts: 6,211

Re: the quote button and img tags are borked

go different home

hummerz5

Member

From: wait I'm not a secret mod huh

Joined: 2015-08-10

Posts: 5,854

Re: the quote button and img tags are borked

who says you can't go home?

can you also explain what went wrong with our img tags here? t hanks

---

thanks HG, HG, HG, HG! anatoly, zumza! zoey!

peace

Member

From: admin land

Joined: 2015-08-10

Posts: 9,226

Re: the quote button and img tags are borked

who says you can't go home?

can you also explain what went wrong with our img tags here? t hanks

whats the point? noneoene can fix cuz only diff can acces the sever

---

thanks hg for making this much better and ty for my avatar aswell

Xfrogman43

Member

From: need to find a new home

Joined: 2015-02-15

Posts: 4,174

Re: the quote button and img tags are borked

who says you can't go home?

can you also explain what went wrong with our img tags here? t hanks

it doesnt quote

[img]

for some reason

check out the post he linked

---

thanks zoey aaaaaaaaaaaand thanks latif for the avatar

Different55

Forum Admin

Joined: 2015-02-07

Posts: 16,575

Re: the quote button and img tags are borked

who says you can't go home?

can you also explain what went wrong with our img tags here? t hanks

Forum tries to strip image tags from quoted text. For some reason in that post it removes the first opening tag and the last closing tag and calls it good. I'm guessing an overly greedy regex or something?

---

"Sometimes failing a leap of faith is better than inching forward"
- ShinsukeIto

Different55

Forum Admin

Joined: 2015-02-07

Posts: 16,575

Re: the quote button and img tags are borked

Right right

nearly forgot about this one

merged with maxi's topic

---

"Sometimes failing a leap of faith is better than inching forward"
- ShinsukeIto

Different55

Forum Admin

Joined: 2015-02-07

Posts: 16,575

Re: the quote button and img tags are borked

Somewhat fixed.

It was not an overly greedy regex, The regex for both the quick quote link (broken) and the dedicated quote page (working) was 100% identical. it was a bug in the regex itself on both pages. But it was a bug in the quick quote code that brought it out.

Whoever wrote the quick quote code escaped the quoted message (which messed with all new lines and special characters) before stripping out the image tags. Turns out the code that strips out image tags *hates* escaped new lines (or actually any non-whitespace text at all) directly in between its img tags. So you can actually still trigger the bug just by inserting your own fake escaped new lines in there:

[img]https://forums.everybodyedits.com/img/smilies/smile.png[/img]\n[img]https://forums.everybodyedits.com/img/smilies/sad.png[/img]

Or other text:

[img]https://forums.everybodyedits.com/img/smilies/smile.png[/img]test[img]https://forums.everybodyedits.com/img/smilies/sad.png[/img]

and it ends up breaking the quote code in the same way, and it works across both the quick quote link and the full quote page.

This is fixed, too, somewhat. It causes some issues of its own, but no new issues.

---

"Sometimes failing a leap of faith is better than inching forward"
- ShinsukeIto