Official Everybody Edits Forums

Gosha

Member

From: Russia

Joined: 2015-03-15

Posts: 6,212

Some bugs in settings page

// This stuff for developers

1) Editkey bug.

▼Hidden text

When you open LevelOptions you get editkey:

If you didn't set code, input that shows code will generate random code:

when you click "save all settings" button, it checks if editkey is different from previous:

and then if it's different - change it. So, basically, if you didn't set editkey it will be random everytime you click "save all settings" button.
And here is the bug:

1) you don't set editkey and give out edits to players with /giveedit command
2) you click "save all settings" without changing editkey
3) editkey gets changed and everyone looses edit.

2) Zombie and Curse effect

▼Hidden text

When you open LevelOptions you get zombie and curse limits:

if you didn't set curse and zombie limit it will return 0.
when you click "save all settings" button, it checks if number in curse/zombie limit is bigger or 0 and less or 75.

And here is the bug:

Curse/zombie limit gets reset everytime to 0. And everytime people who currently have zombie/curse effect - lose it.

Personal solution: Remove zombie and curse limits. Nobody uses it because it doesn't work. It wasn't working since the day it was released!

3) not a bug, just little bit of bad coding:

▼Hidden text

Very useless switch()

Here is my code:

      private function handleConfirmAction(param1:MouseEvent) : void
      {
         if(this.confirmAction == "save") Global.base.showLoadingScreen("Saving World");
         this.connection.send("say", "/" + this.confirmAction);
         this.close();
         this.confirmAction = "none";
         Actions.Confirm.visible = false;
      }

/clear and /save are in the game now . no need to make personal messagetypes for them

4) Little bit of bad coding

▼Hidden text

First: too many ! here.
here is a fix:

            var _loc2_:* = Permissions.showlobby_checkbox.currentFrame == 1;
            if(levelHideLobby != _loc2_)
            {
               con.send("setHideLobby",_loc2_);
               levelHideLobby = _loc2_;
            }

Second: "Showlobby" "HideLobby" - this gets very confusing.
in game it shows "show this world in lobby", but the actual message you send is "setHideLobby"
Make it a one thing. Hide or show. No need to go from one to another.

peace

Member

From: admin land

Joined: 2015-08-10

Posts: 9,226

Re: Some bugs in settings page

for number 3 we coudl remov ethe saving world screen cuz what if too much data from signs and it cant save ur stuck wiht that screen just us esomentthing diffrent

---

thanks hg for making this much better and ty for my avatar aswell

Gosha

Member

From: Russia

Joined: 2015-03-15

Posts: 6,212

Re: Some bugs in settings page

for number 3 we coudl remov ethe saving world screen cuz what if too much data from signs and it cant save ur stuck wiht that screen just us esomentthing diffrent

Can you freaking look at your message before clicking "Submit" button?

"could", "remove", "the", "with", "something", "different"
6 spelling mistakes in one sentence!
_____

Also, that issue is with PlayerIO size limits.

hummerz5

Member

From: wait I'm not a secret mod huh

Joined: 2015-08-10

Posts: 5,854

Re: Some bugs in settings page

on the other hand, #3, if they planned on extending the types of confirming prompts then a switch would be useful (assuming it would have some complexity greater than what you present)

and #4 if the currentFrame becomes something that could have more states than one or two, then wouldn't that potentially change the logic you have? it'd no longer be !A, therefore B. Could be !A, therefore B or C.

but for the information you have now, I think these are good points. On behalf of whoever might implement these changes, thanks!

---

thanks HG, HG, HG, HG! anatoly, zumza! zoey!

LukeM

Member

From: England

Joined: 2016-06-03

Posts: 3,009

Website

Re: Some bugs in settings page

With 3 what they did would (imo) be the better way of doing it, because 1. as Hummerz5 says it allows for more options to be easily added without breaking everything, and 2. it doesnt rely on the client side action names being the same as server side commands (although the close could be moved outside the switch probably (unless theres other possible actions like "none" or "close" or whatever))

for number 3 we coudl remov ethe saving world screen cuz what if too much data from signs and it cant save ur stuck wiht that screen just us esomentthing diffrent

Cab you freaking look at your message before clicking "Submit" button?

"could", "remove", "the", "with", "something", "different"
6 spelling mistakes in one sentence!

Thats actually quite good for one of peace's posts