Official Everybody Edits Forums

SirJosh3917

Formerly ninjasupeatsninja

From: USA

Joined: 2015-04-05

Posts: 2,095

"write"'s gayness

can we change write

i hate having to deal with PMs

string 0 could be:
"* NOOB > YOU"
"* YOU > NOOB"
"* SYSTEM"
"* WORLD"
"* MAGIC"

and string 2 is the chat message can we have it like

0: int
1: string
2: string

int 0:

0 - from the system
1 - from a player
2 - you're sending it to someone

string 1: the name of the player that you're recieving it from, or SYSTEM, e.t.c
string 2: message

i dont have the best solution currently, but it's super weird currently and not very nice to deal wit hat all..

and yes, EE sends you "* YOU > PLAYER: msg", it's not client side as you'd expect.

---

Scarlet - EE & EEU Minimaps for the forums

Smiley Face Game | Join Discord

Finance me. I want your money.

LukeM

Member

From: England

Joined: 2016-06-03

Posts: 3,009

Website

Re: "write"'s gayness

This is just an overcomplicated example from a very old bot.

▼Trigger over-engineered code waring

        public void sayAdd(String pre, String msg)
        {
            sayQueue.Enqueue(pre + "[Bot]: " + msg);
        }

        public void whisperAdd(int id, String pre, String msg)
        {
            if (players.ContainsKey(id))
            {
                Player player;
                players.TryGetValue(id, out player);

                player.whispers.Enqueue(pre + "[Bot]: " + msg);
            }
        }

        public void sayAdd(String msg)
        {
            sayAdd("", msg);
        }

        public void sayWhisper(int id, String msg)
        {
            if (players.ContainsKey(id))
            {
                Player player;
                players.TryGetValue(id, out player);

                if (player.botChat)
                {
                    whisperAdd(id, "/pm " + player.username + " ", msg);
                }
            }
        }

        public void sayTp(int id, int x, int y)
        {
            if (players.ContainsKey(id))
            {
                Player player;
                players.TryGetValue(id, out player);

                say("/tp " + player.username + " " + x + " " + y + " ");
            }
        }

        public void sayTeam(Team team, string msg)
        {
            foreach (KeyValuePair<int, Player> entry in players)
            {
                if (entry.Value.team != null)
                {
                    if (entry.Value.team.color == team.color)
                    {
                        sayWhisper(entry.Value.id, msg);
                    }
                }
            }
        }

You call that overcomplicated???

I once had a 150+ line mess of code that queued messages (had seperate queues for each players PMs, global chat, commands etc), split messages at convenient points (it would split it trying to keep the messages as long as possible, but also not cut at confusing places, e.g. in the middle of words, or sometimes list items), auto generate a load of commands, etc.

Edit: seems they deleted it, but ill this here because I put time into it );

Tomahawk

Forum Mod

From: UK

Joined: 2015-02-18

Posts: 2,847

Re: "write"'s gayness

You only have to write the parsing function once. It's not that hard.

---

One bot to rule them all, one bot to find them. One bot to bring them all... and with this cliché blind them.

Swarth100

Member

Joined: 2015-07-18

Posts: 305

Re: "write"'s gayness

This is just an overcomplicated example from a very old bot.

▼Trigger over-engineered code waring

        public void sayAdd(String pre, String msg)
        {
            sayQueue.Enqueue(pre + "[Bot]: " + msg);
        }

        public void whisperAdd(int id, String pre, String msg)
        {
            if (players.ContainsKey(id))
            {
                Player player;
                players.TryGetValue(id, out player);

                player.whispers.Enqueue(pre + "[Bot]: " + msg);
            }
        }

        public void sayAdd(String msg)
        {
            sayAdd("", msg);
        }

        public void sayWhisper(int id, String msg)
        {
            if (players.ContainsKey(id))
            {
                Player player;
                players.TryGetValue(id, out player);

                if (player.botChat)
                {
                    whisperAdd(id, "/pm " + player.username + " ", msg);
                }
            }
        }

        public void sayTp(int id, int x, int y)
        {
            if (players.ContainsKey(id))
            {
                Player player;
                players.TryGetValue(id, out player);

                say("/tp " + player.username + " " + x + " " + y + " ");
            }
        }

        public void sayTeam(Team team, string msg)
        {
            foreach (KeyValuePair<int, Player> entry in players)
            {
                if (entry.Value.team != null)
                {
                    if (entry.Value.team.color == team.color)
                    {
                        sayWhisper(entry.Value.id, msg);
                    }
                }
            }
        }

You call that overcomplicated???

I once had a 150+ line mess of code that queued messages (had seperate queues for each players PMs, global chat, commands etc), split messages at convenient points (it would split it trying to keep the messages as long as possible, but also not cut at confusing places, e.g. in the middle of words, or sometimes list items), auto generate a load of commands, etc.

Edit: seems they deleted it, but ill this here because I put time into it );

Ahahah
I figured that ninja was worried about "write" commands and I answered regarding "say"

I personally consider over complicated code anything that isn't modular nor scaleable, and back in the day I had none of the two in mind XD

realmaster42

Formerly marcoantonimsantos

From: ̍̍̍̍̍̍̍̍̍̍̍̍̍̍̍̍̍̍̍̍̍̍̍̍̍̍̍̍̍

Joined: 2015-02-20

Posts: 1,380

Website

Re: "write"'s gayness

But, this is not how "write" works.

"write" is used in much more things than you think.
Every time you get a "* SYSTEM" message it's "write".
A "* WORLD" message is "write".

And sometimes, some other words are "write"...
"write" is good as it is, and parsing PMs is of the easiest things to do...

string msg = pm.Substring(pm.IndexOf(":"));

---

SirJosh3917

Formerly ninjasupeatsninja

From: USA

Joined: 2015-04-05

Posts: 2,095

Re: "write"'s gayness

But, this is not how "write" works.

"write" is used in much more things than you think.
Every time you get a "* SYSTEM" message it's "write".
A "* WORLD" message is "write".

And sometimes, some other words are "write"...
"write" is good as it is, and parsing PMs is of the easiest things to do...

string msg = pm.Substring(pm.IndexOf(":"));

...can we have it like

0: int
1: string
2: string

int 0:

0 - from the system
1 - from a player
2 - you're sending it to someone

...

and yes, EE sends you "* YOU > PLAYER: msg", it's not client side as you'd expect.

---

Scarlet - EE & EEU Minimaps for the forums

Smiley Face Game | Join Discord

Finance me. I want your money.

den3107

Member

From: Netherlands

Joined: 2015-04-24

Posts: 1,025

Re: "write"'s gayness

Slightly off-topic:

I once had a 150+ line mess of code that queued messages (had seperate queues for each players PMs, global chat, commands etc), split messages at convenient points (it would split it trying to keep the messages as long as possible, but also not cut at confusing places, e.g. in the middle of words, or sometimes list items), auto generate a load of commands, etc.

Glad to know I'm not the only one who did that... I kinda had a single class though, and I just made an object for PMs, an object for global, etc.

italkalotfromee

Member

Joined: 2015-05-08

Posts: 117

Re: "write"'s gayness

            if (m.Type == "write")
            {
                string user = m.GetString(0).Split(' ')[1];
                string[] msg = m.GetString(1).Split(' ');
                if (msg[0] == "help")
                {
                    Bot.pmUser(user, "Commands go here");
                }
            }

This worked for me. Very simple for a crappy programmer as some people see me. xD

---

SirJosh3917

Formerly ninjasupeatsninja

From: USA

Joined: 2015-04-05

Posts: 2,095

Re: "write"'s gayness

but guys what if a player's name is YOU.

and he pms a perosn

YOU > YOU

auto bot inferences will be made if the bot pms someone and ugly stuff all around

there are underlying foundational problems here

---

Scarlet - EE & EEU Minimaps for the forums

Smiley Face Game | Join Discord

Finance me. I want your money.

italkalotfromee

Member

Joined: 2015-05-08

Posts: 117

Re: "write"'s gayness

but guys what if a player's name is YOU.

and he pms a perosn

YOU > YOU

auto bot inferences will be made if the bot pms someone and ugly stuff all around

there are underlying foundational problems here

With the method I use you won't have that problem, but i can see what you're getting at.

---