Official Everybody Edits Forums

Do you think I could just leave this part blank and it'd be okay? We're just going to replace the whole thing with a header image anyway, right?

You are not logged in.

#26 2016-09-17 14:25:45

Tomahawk
Forum Mod
From: UK
Joined: 2015-02-18
Posts: 2,847

Re: [Guide] Understanding how a EE Bot works, and how to make one.

BananaMilkShake wrote:

Just leaving a question,
If I fill the world using my bot. My bot doesn't pick up any commands until it finished filling up the world.
Is this perfectly natural or is there a magic trick to avoid it?

There is a magic trick, involving threading.

Put your fill code into its own method, and then run it in a new thread. No spoonfeeding from me.


One bot to rule them all, one bot to find them. One bot to bring them all... and with this cliché blind them.

Offline

#27 2016-09-18 08:57:06

Vinyl Melody
Formerly BananaMilkShake
Joined: 2016-06-19
Posts: 616

Re: [Guide] Understanding how a EE Bot works, and how to make one.

Tomahawk wrote:

There is a magic trick, involving threading.

Put your fill code into its own method, and then run it in a new thread. No spoonfeeding from me.

Sadly, even putting my own code into it's own void didn't work. //forums.everybodyedits.com/img/smilies/sad


cb0de83627.png
Thanks to: Ernesdo (Current Avatar), Zoey2070 (Signature)

Very inactive, maybe in the future, idk.

Offline

#28 2016-09-18 11:08:52

MartenM
Member
From: The Netherlands
Joined: 2016-03-31
Posts: 978
Website

Re: [Guide] Understanding how a EE Bot works, and how to make one.

BananaMilkShake wrote:

Sadly, even putting my own code into it's own void didn't work.

I can help you if you want. Just PM me //forums.everybodyedits.com/img/smilies/wink
Btw I am not the person to straight out fix it for you because this will result in you not understanding it.


lm3hgg8.jpg

Ingame: marten22        My steam: MartenM

Offline

#29 2016-09-18 19:59:31

Tomahawk
Forum Mod
From: UK
Joined: 2015-02-18
Posts: 2,847

Re: [Guide] Understanding how a EE Bot works, and how to make one.

There's so many things missing or misinforming in this tutorial that I can't even begin to list them.

Firstly, this teaches new botters to use a console, which [opinion] has huge disadvantages over Windows Forms in terms of the code required, especially in operations such as inputting information and triggering bot actions [/opinion]. Please add a winforms tutorial and compare it to console so the user can decide which to use - which they can't, because you've only used console code.

You stress that only a small amount of C# knowledge is required (without linking any external C# tutorials), then display a coded class and dictionary that the user is bound to find confusing with only a little bit of knowledge. Why even put a class with one string in it into a dictionary? - so that other variables can be added in future, but you don't explain that, or list the alternative <int, string> for users who don't need a player class.

You don't explain namespaces, your connect code, what a switch does, what += does for OnMessage, why you send "init" or "init2", what's being added to the dictionary in "add", what PlayerIO is, why you need the dll, what the "Client" and "Connection" variables are for, what "Thread.Sleep" is and why you need it in the connect code (you don't), and you've barely even touched on what a PlayerIOClient message actually is.

You pack all your connect code into two lines, with no error callback checking whatsoever, and with two ternary operators you're pretty much asking to be copy/pasted. There's a danger with every coding tutorial of it establishing its contents as THE one way to do things, but you've gone past that and written:

ninjasupeatsninja wrote:

Let's make sure you have all the code correct in your bot.

And displayed all the code again to be copied. As Humvee said:

hummerz5 wrote:

I've said it multiple times: my concern with copy and paste is that most prospective "learners" do not understand what they're facing. They then become reliant on someone else's copy/paste code.

This tutorial isn't a good learning tool because you've explained very little of the code and underlying bot theory, and so it's unlikely that a newbie botter will be able to confidently add more code to the core bot they get after following the tutorial.

There aren't enough features in a beginner bot that require use of the basic C# (variables, methods, loops, conditional logic, arrays, lists etc.) necessary to build up a general understanding of the language. You have to stress that C# and bot coding are separate things that should be learned in the correct order.

[/rant]

I'm not quite entirely butthurt, because the bot you end up with will run, but this tutorial goes about things the wrong way. Credits to you for trying, but it's naïve at best to hope to fit an entire bot tutorial into a forum post, and no tutorial can be well-rounded without contribution from multiple people. What would be better is to start a new bot-coding wiki to which multiple coders can add their own explanations and versions of code to topics, and where everything is split up into its own little section with theory first and code second.

You need to add links to other bot tutorials on this forum (like Jaba's) and to beginner C# tutorials (like Homeandlearn). Also introduce StackOverflow and MSDN's C# documentation.


One bot to rule them all, one bot to find them. One bot to bring them all... and with this cliché blind them.

Offline

Wooted by: (2)

#30 2016-09-18 20:15:13

Calyfornia
Member
From: Scotland
Joined: 2016-07-09
Posts: 41

Re: [Guide] Understanding how a EE Bot works, and how to make one.

Tomahawk wrote:

two ternary operators you're pretty much asking to be copy/pasted.

Probably were to begin with, to be honest...

https://forums.everybodyedits.com/viewt … p?id=26179

U2RgROa.png


EENeat | Teaches itself how to play EE (Made in partnership with Jesse)
Rider   | Cross-platform, alternative C# IDE by JetBrains.

Offline

#31 2016-09-18 20:21:38

MartenM
Member
From: The Netherlands
Joined: 2016-03-31
Posts: 978
Website

Re: [Guide] Understanding how a EE Bot works, and how to make one.

Tomahawk wrote:

what += does for OnMessage

Hahaha, I still don't know exactly

;-;


lm3hgg8.jpg

Ingame: marten22        My steam: MartenM

Offline

Wooted by:

#32 2016-09-18 21:44:07

Vinyl Melody
Formerly BananaMilkShake
Joined: 2016-06-19
Posts: 616

Re: [Guide] Understanding how a EE Bot works, and how to make one.

MartenM wrote:

Btw I am not the person to straight out fix it for you because this will result in you not understanding it.

I can't even understand my codes... a bit.


cb0de83627.png
Thanks to: Ernesdo (Current Avatar), Zoey2070 (Signature)

Very inactive, maybe in the future, idk.

Offline

#33 2016-09-18 21:52:07

capasha
Member
Joined: 2015-02-21
Posts: 4,066

Re: [Guide] Understanding how a EE Bot works, and how to make one.

BananaMilkShake wrote:
MartenM wrote:

Btw I am not the person to straight out fix it for you because this will result in you not understanding it.

I can't even understand my codes... a bit.

Maybe there is a way to read more tutorials for C#?

Offline

#34 2016-09-19 00:00:31

SirJosh3917
Formerly ninjasupeatsninja
From: USA
Joined: 2015-04-05
Posts: 2,095

Re: [Guide] Understanding how a EE Bot works, and how to make one.

MartenM wrote:
Tomahawk wrote:

what += does for OnMessage

Hahaha, I still don't know exactly

;-;

Here's a simple example:

Let's say you have a

string Tutorial = "AB";

If you do

Tutorial += "C";

, Tutorial will now be equal to

ABC

.

The OnMessage += functions in the same way, except not with strings, with delegates ( delegates/voids/Action ).

Offline

SirJosh39171474239631623606

Board footer

Powered by FluxBB

[ Started around 1732421034.0596 - Generated in 0.073 seconds, 12 queries executed - Memory usage: 1.62 MiB (Peak: 1.81 MiB) ]