Subscribe to thread error

Koya · 2016-09-12 00:20:48

Ability to subscribe and unsubscribe still works but doesn't appear so.

Clicking the "Subscribe to this thread" link sends you to a page with an error "Bad CSRF hash. You were referred to this page from an unauthorized source.", going back to the page the link still says "Subscribe..." and emails will be sent for posts; clicking it again returns you to the page and the link changes to "unsubscribe..."; the same weirdness happens in reverse.

hummerz5 · 2016-09-12 01:03:12

FWIW: My subscription buttons are working. I usually only click them accidentally. Which topic are you testing?

Browser?

OS?

Cereal number?

Kaleb · 2016-09-12 01:23:35

Mine usually works, I don't really know what the problem is.

Ratburntro44 · 2016-09-12 01:44:13

That language matches $lang_common['Bad csrf hash'], and the only function that uses $lang_common['Bad csrf hash'] is check_csrf in include/functions.php

This function is only called in logging out, some moderator actions, deleting your avatar, marking stuff as read, and subscribing or unsubscribing. Given that the others shouldn't be involved here at all, it should be directly in the subscribing/unsubscribing process.

If you're redirected to $lang_common['Bad csrf hash'], then that means your csrf token was either nonexistent or unauthorized. Reasons for this could be if you changed your password separately before following a link from a page you opened prior to the password change, if your IP address had changed after you opened the link, or if you somehow opened an altered version of the link.

When this is activated, it shouldn't do anything past this in the subscription code and your subscription status shouldn't be changed. This matches with what I get when I do it by intentionally altering the subscription link.

I can't imagine how the subscription data would be altered while also getting a csrf error unless Diff made some weird changes in the subscribing code. I also can't imagine how it would end up listing links that don't match your status unless you are seeing the links from a cached version of the page.

Different55 · 2016-09-12 02:19:10

Diff has not made any changes to the subscribing code, let alone weird ones.

hummerz5

Ratburntro44 · 2016-09-12 02:43:51

tfw i try to leave helpful info and diff just makes some weird comment on an unimportant part of my post

also btw everything i said is based on fluxbb 1.5.10 so there is a chance whatever the forums are currently on might be slightly different

Different55 · 2016-09-12 03:01:33

Patches have been applied to bring us up to 1.5.10

Ratburntro44 · 2016-09-13 15:23:54

Okay, the best explanation I can think of is
- you clicked the subscribe button
- the request was sent
- your internet connection changed while loading, and your browser sent a new request
- this request got a csrf error since you were on a new up
- the old request still changed your subscription status
- you went back to a cached version of the page that still had a subscribe button
- then ??????? I'm not totally sure what your description is saying beyond that point

Is this happening repeatedly, on a stable internet connection? If so then this explanation doesn't really make sense, but I'm not sure what else it could be here.

Edit: by total coincidence my wifi disconnected after posting this and I accidentally pressed the subscribe button, and got a similar result to this

hummerz5 · 2016-09-13 22:12:26

koya, you don't happen to be running any of those fancy addons you carry around every now and then that might be making requests that mess up the csrf?

Koya · 2016-09-14 00:01:07

hummerz5 wrote:

koya, you don't happen to be running any of those fancy addons you carry around every now and then that might be making requests that mess up the csrf?

Nothing that would be causing this error.

Edit: Closed b/c as far as I know this is fixed.

Official Everybody Edits Forums

#1 2016-09-12 00:20:48

Subscribe to thread error

#2 2016-09-12 01:03:12

Re: Subscribe to thread error

#3 2016-09-12 01:23:35

Re: Subscribe to thread error

#4 2016-09-12 01:44:13

Re: Subscribe to thread error

#5 2016-09-12 02:19:10

Re: Subscribe to thread error

#6 2016-09-12 02:43:51

Re: Subscribe to thread error

#7 2016-09-12 03:01:33

Re: Subscribe to thread error

#8 2016-09-13 15:23:54, last edited by Ratburntro44 (2016-09-13 15:27:02)

Re: Subscribe to thread error

#9 2016-09-13 22:12:26

Re: Subscribe to thread error

#10 2016-09-14 00:01:07, last edited by Koya (2016-09-18 11:59:55)

Re: Subscribe to thread error

Board footer