[Help] Bot detecting players who joins.

Vinyl Melody · 2016-08-31 11:40:28

My bot is detecting players who joins the world after it joins... not the players who already joined...
I already used con.Send("init2");
Help D: It was working before, I dont know what went wrong!

realmaster42

realmaster42 · 2016-08-31 11:58:56

BananaMilkShake wrote:

My bot is detecting players who joins the world after it joins... not the players who already joined...
I already used con.Send("init2");
Help D: It was working before, I dont know what went wrong!

Only use con.Send("init2") before the end of init.
If you use a switch it must be before break; or return; and if not it must be before the }.

Vinyl Melody · 2016-08-31 12:04:37

marcoantonimsantos wrote:

Only use con.Send("init2") before the end of init.

case "init":
					{
						blah blah blah some random codes
						con.Send("init2");
					}
					break;

den3107 · 2016-08-31 12:07:20

Can you show us a little bit more code?
For example post it on pastebin or github.
We can't really help you without making random guesses right now.

Vinyl Melody · 2016-08-31 12:09:42

▼Full noob code

case "init":
{
if(m.GetBoolean(15) == false)
{
MessageBox.Show("Im not the owner! Disconnecting", "SweetieBot Error", MessageBoxButtons.OK, MessageBoxIcon.Error);
Thread.Sleep(750);
isConnected = false;
connect_Button.Text = "Connect";
con.Disconnect();
// Rip making this bot go to another world that isn't yours
}
if(creator != m.GetString(0))
{
owner = m.GetString(0);
}
worldx = m.GetInt(18);
worldy = m.GetInt(19);
foreach (DataChunk dataChunk in InitParsing.Parse(m))
{
foreach (Point location in dataChunk.Locations)
{
blocks[dataChunk.Layer, location.X, location.Y] = (int) dataChunk.Type;
blockL.Add(new block()
   {
   layer = dataChunk.Layer,
   x = location.X,
   y = location.Y,
   bid = (int) dataChunk.Type,
   args = dataChunk.Args
   });
}
}
LoadAdmins();
LoadBans();
freedit = false;
noinfect = false;
ninjarobber = false;
guest = false;
if(!admins.Contains(owner))
{
AddAdmins(owner);
}
con.Send("init2");
}
break;

realmaster42 · 2016-08-31 14:14:42

Why do you start it with { and finish with }??? I don't see any IF statement so I am in doubt if your code even runs

hummerz5 · 2016-08-31 15:06:01

marcoantonimsantos wrote:

Why do you start it with { and finish with }??? I don't see any IF statement so I am in doubt if your code even runs

I used to think that, but apparently the lack of braces is just an earmark of an old Visual Studio; apparently the braces are nice to help with variable naming and stuff... organization idk

Tomahawk · 2016-08-31 15:21:43

@Milkshake:
You should really send "init2" at the start of "init", so that your bot initialises everything more quickly after it connects. It also might be the problem here.

Putting { } to surround code is perfectly fine, and brings no compiler errors as long as the braces match up.

Vinyl Melody · 2016-08-31 22:11:35

Tomahawk wrote:

@Milkshake:
You should really send "init2" at the start of "init", so that your bot initialises everything more quickly after it connects. It also might be the problem here.

Still didn't work :/
I think the problem is in the init code.
Still have to re-join for the bot to check and add.

den3107 · 2016-08-31 22:21:52

What if you just start commenting out stuff?
Start with the bot-specific stuff (like the non-owner stuff), and gradually work your way down until you even comment the deserialization stuff.
If it still doesn't work when you have just "con.send("init2")", then we have one of those "special cookie" bots/pcs that'll be a hell to uncover why stuff isn't working.

Reason why it's usually best to start commenting part by part instead of going straight to just the init2 send stuff, is because with this method you will very easily know where the problem is.

Tomahawk wrote:

You should really send "init2" at the start of "init", so that your bot initializes everything more quickly after it connects.

Don't see how that would make your initialization faster... You might cut down a bit of idle time, but the initialization will always go just as long.

hummerz5 · 2016-08-31 23:51:00

well it lets the server know you're on the right page, which is faster than waiting to tell the server until you're actually done

Tomahawk · 2016-08-31 23:51:28

den3107 wrote:

Don't see how that would make your initialization faster

The server sends the "add" messages and some other stuff as soon as "init2" is sent, so the sooner it's sent, the faster they're processed.

It's only a little bit faster.

Vinyl Melody · 2016-09-01 07:22:21

Turns out the block loading is slow and the world that im currently using as bot testing has many backgrounds and some random code. But it works now, thanks!
Thread Close? please.

realmaster42 · 2016-09-01 12:30:19

You can close it yourself by clicking Lock at the bottom of the page

Koya · 2016-09-01 14:36:29

BananaMilkShake wrote:

Turns out the block loading is slow and the world that im currently using as bot testing has many backgrounds and some random code. But it works now, thanks!
Thread Close? please.

Use InitParse https://gist.github.com/Yonom/3c9ebfe69b1432452f9b

Literally takes 3 seconds to load 300x300 world (and draw minimap)

Vinyl Melody · 2016-09-01 22:14:40

How to use InitParse? It always gives me an error when using it.
Edit: Nevermind, I fixed it. Thanks for the help!

Official Everybody Edits Forums

#1 2016-08-31 11:40:28

[Help] Bot detecting players who joins.

#2 2016-08-31 11:58:56

Re: [Help] Bot detecting players who joins.

#3 2016-08-31 12:04:37

Re: [Help] Bot detecting players who joins.

#4 2016-08-31 12:07:20

Re: [Help] Bot detecting players who joins.

#5 2016-08-31 12:09:42

Re: [Help] Bot detecting players who joins.

#6 2016-08-31 14:14:42

Re: [Help] Bot detecting players who joins.

#7 2016-08-31 15:06:01

Re: [Help] Bot detecting players who joins.

#8 2016-08-31 15:21:43

Re: [Help] Bot detecting players who joins.

#9 2016-08-31 22:11:35

Re: [Help] Bot detecting players who joins.

#10 2016-08-31 22:21:52

Re: [Help] Bot detecting players who joins.

#11 2016-08-31 23:51:00

Re: [Help] Bot detecting players who joins.

#12 2016-08-31 23:51:28

Re: [Help] Bot detecting players who joins.

#13 2016-09-01 07:22:21

Re: [Help] Bot detecting players who joins.

#14 2016-09-01 12:30:19

Re: [Help] Bot detecting players who joins.

#15 2016-09-01 14:36:29

Re: [Help] Bot detecting players who joins.

#16 2016-09-01 22:14:40, last edited by Vinyl Melody (2016-09-02 06:06:12)

Re: [Help] Bot detecting players who joins.

Board footer