[Resolved] About Graphics

SirJosh3917 · 2015-09-25 03:18:33

answer:

		public void InitializationCode()
		{
			Debug.WriteLine("\n");
			Debug.WriteLine("InitializationCode() Activated");
			int sizeW = GameFrame.Size.Width;
			int sizeH = GameFrame.Size.Height;
			Debug.WriteLine(sizeW.ToString() + "//" + sizeH.ToString());
			Bitmap a = new Bitmap(sizeW, sizeH);
			if (SetupGame.FillScreen)
			{
				for (int y = 0; y < a.Height; y++)
				{
					for (int x = 0; x < a.Width; x++)
					{
						a.SetPixel(x, y, SetupGame.FillScreenColor);
					}
				}
				GUI = a;
				GameFrame.Image = GUI;
			}
		}

Hello. I am trying to make a game template, mainly because I'm interested with Bitmap, PictureBox, and Graphics. I have the following code:

			GUI = new Bitmap(GameFrame.Image.Width, GameFrame.Image.Width);
			if (SetupGame.FillScreen)
			{
				Graphics g = Graphics.FromImage(GUI);
				g.FillRectangle(new SolidBrush(SetupGame.FillScreenColor), new Rectangle(0, 0, GameFrame.Image.Width - 2, GameFrame.Image.Height - 2));
				g.Save();
				GUI = new Bitmap(GameFrame.Image.Width, GameFrame.Image.Width, g);
				GameFrame.Image = GUI;
				g.Dispose();
			}

public static Bitmap GUI;

	class SetupGame
	{

		/*
		 * 
		 * Setup the game using these options
		 * 
		 * Just modify them, the game will take place
		 * 
		 * From [cencored my irl name], 9/24/2015 10:06 PM
		 * 
		 */

		public static bool FillScreen = true;
		public static Color FillScreenColor = Color.Red;
	}

I cannot find out what's going on.
The current code as stated in the first code box doesn't draw a rectangle. The width and height of the GameFrame (Picturebox) is 484, 462

hummerz5 · 2015-09-25 03:29:49

I don't feel particularly inclined to do all the steps required to properly debug your code

Personally I haven't ever created a new bitmap on top of one that I've already created.
Seems backwards.

I'm thinking your bug is due to the misspelling of the word "censor".

edit:
Ok, turns out I am motivated enough to humor this bug
And yes, it's what I thought it was.
Why do you even bother making GUI a larger-scope variable if you're going to completely pull a new bitmap every time?

SirJosh3917 · 2015-09-25 03:52:22

hummerz5 wrote:

Why do you even bother making GUI a larger-scope variable if you're going to completely pull a new bitmap every time?

This is the bigger scope

using System;
using System.Collections.Generic;
using System.ComponentModel;
using System.Data;
using System.Drawing;
using System.Linq;
using System.Text;
using System.Threading.Tasks;
using System.Windows.Forms;

namespace Image_Game
{
	public partial class Form1 : Form
	{



		public Form1()
		{
			InitializeComponent();
		}

		public static Bitmap GUI;

		private void Form1_Load(object sender, EventArgs e)
		{
			GUI = new Bitmap(GameFrame.Image.Width, GameFrame.Image.Width);
			if (SetupGame.FillScreen)
			{
				Graphics g = Graphics.FromImage(GUI);
				g.FillRectangle(new SolidBrush(SetupGame.FillScreenColor), new Rectangle(0, 0, GameFrame.Image.Width - 2, GameFrame.Image.Height - 2));
				g.Save();
				GUI = new Bitmap(GameFrame.Image.Width, GameFrame.Image.Width, g);
				GameFrame.Image = GUI;
				g.Dispose();
			}
		}
	}
}

capasha · 2015-09-25 03:55:38

You can't dispose GUI when it's loaded in the picturebox.

hummerz5 · 2015-09-25 13:43:25

@capasha: basically that. really.

@ninja: Alright, so you're initializing your image. Closer to reasonable. Yet you're still overwriting the whole thing... not sure why

SirJosh3917 · 2015-09-25 21:37:43

I tried removing "g.dispose()" and that did nothing. I now have this code

using System;
using System.Collections.Generic;
using System.ComponentModel;
using System.Data;
using System.Drawing;
using System.Linq;
using System.Text;
using System.Threading.Tasks;
using System.Windows.Forms;
using System.Diagnostics;

namespace Image_Game
{
	public partial class Form1 : Form
	{
		public Form1()
		{
			InitializeComponent();
		}

		public Bitmap GUI;

		public void InitializationCode()
		{
			Debug.WriteLine("\n\n\n\n\n\n\n\n\n");
			Debug.WriteLine("Form Loaded");
			int sizeW = GameFrame.Size.Width;
			int sizeH = GameFrame.Size.Height;
			Debug.WriteLine(sizeW.ToString() + "//" + sizeH.ToString());
			Bitmap a = new Bitmap(sizeW, sizeH);
			if (SetupGame.FillScreen)
			{
				Graphics g = Graphics.FromImage(a);
				g.FillRectangle(new SolidBrush(SetupGame.FillScreenColor), new Rectangle(0, 0, sizeW - 2, sizeH - 2));
				a = new Bitmap(sizeW, sizeH, g);
				GameFrame.Image = a;
				GUI = a;
			}
			GameFrame.Refresh();
		}

		private void Form1_Load(object sender, EventArgs e)
		{
			InitializationCode();
		}

		private void MouseMoved(object sender, MouseEventArgs e)
		{

		}

		private void button1_Click(object sender, EventArgs e)
		{
			InitializationCode();
		}
	}
}

I am completely stumped.
Here's the debug data:

Form Loaded
484//462

hummerz5 · 2015-09-25 22:07:01

But g.Dispose is the graphics, not the bitmap

What are you going on about?

srs tho, stop overwriting the bitmap and you'll be fine

SirJosh3917 · 2015-09-25 22:08:32

hummerz5 wrote:

But g.Dispose is the graphics, not the bitmap
What are you going on about?

you guys said i was disposing GUI, but I didn't see GUI.Dispose();
So I figured you were talking about the Graphics g.
If you are really talking about GUI, where did I dispose it?

EDIT:
I can't define the bitmap as a new bitmap with GameFrame.Size.Width or Height, So i have do define it at Form1_Load()

hummerz5 · 2015-09-25 22:56:53

I never said "Dispose" but ofc.

I'm somewhat curious why the forums have let this little conversation take so long
The problem is rather plain as day, yet here we are, discussing it to no avail. I wonder how far we can push it?

Major hint: you aren't defining it once.

SirJosh3917 · 2015-09-25 23:42:54

hummerz5 wrote:

I never said "Dispose" but ofc.
I'm somewhat curious why the forums have let this little conversation take so long
The problem is rather plain as day, yet here we are, discussing it to no avail. I wonder how far we can push it?
Major hint: you aren't defining it once.

I don't understand what you mean by I'm not defining it once. I'll ask on stack over flow
@mods: you can lock if you choose to.

capasha · 2015-09-26 02:14:53

Also. Remove "a = new Bitmap(sizeW, sizeH, g);" and everything should work.
I have no idea why you are using it two times.

SirJosh3917 · 2015-09-26 02:20:14

capasha wrote:

Also. Remove "a = new Bitmap(sizeW, sizeH, g);" and everything should work.
I have no idea why you are using it two times.

I do it twice because I need to convert the new generated graphics into a bitmap

SirJosh3917 · 2015-09-26 02:59:24

I have decided to simply do

		public void InitializationCode()
		{
			Debug.WriteLine("\n");
			Debug.WriteLine("InitializationCode() Activated");
			int sizeW = GameFrame.Size.Width;
			int sizeH = GameFrame.Size.Height;
			Debug.WriteLine(sizeW.ToString() + "//" + sizeH.ToString());
			Bitmap a = new Bitmap(sizeW, sizeH);
			if (SetupGame.FillScreen)
			{
				for (int y = 0; y < a.Height; y++)
				{
					for (int x = 0; x < a.Width; x++)
					{
						a.SetPixel(x, y, SetupGame.FillScreenColor);
					}
				}
				GUI = a;
				GameFrame.Image = GUI;
			}
		}

It seems to be doing well and fast.
@mods: lock plz

hummerz5

Official Everybody Edits Forums

#1 2015-09-25 03:18:33, last edited by SirJosh3917 (2015-09-26 03:00:02)

[Resolved] About Graphics

#2 2015-09-25 03:29:49, last edited by hummerz5 (2015-09-25 03:35:08)

Re: [Resolved] About Graphics

#3 2015-09-25 03:52:22

Re: [Resolved] About Graphics

#4 2015-09-25 03:55:38

Re: [Resolved] About Graphics

#5 2015-09-25 13:43:25

Re: [Resolved] About Graphics

#6 2015-09-25 21:37:43

Re: [Resolved] About Graphics

#7 2015-09-25 22:07:01, last edited by hummerz5 (2015-09-25 22:08:06)

Re: [Resolved] About Graphics

#8 2015-09-25 22:08:32, last edited by SirJosh3917 (2015-09-25 22:09:13)

Re: [Resolved] About Graphics

#9 2015-09-25 22:56:53

Re: [Resolved] About Graphics

#10 2015-09-25 23:42:54

Re: [Resolved] About Graphics

#11 2015-09-26 02:14:53

Re: [Resolved] About Graphics

#12 2015-09-26 02:20:14

Re: [Resolved] About Graphics

#13 2015-09-26 02:59:24

Re: [Resolved] About Graphics

Board footer