[World Deserializer] Halp

realmaster42 · 2015-03-06 22:27:57

The first time works correctly, but second doesn't...

Anyone knows how to fix?

while (c < m.Count && !(m[c].ToString().StartsWith("PW") || m[c].ToString().StartsWith("BW")))
            {
                if (m[c].ToString() != "we")
                {
                    int bid = m.GetInt(c);
                    for (int n = 0; n < m.GetByteArray(c + 2).Length; n += 2)
                    {
                        int x = m.GetByteArray(c + 2)[n] << 8 | m.GetByteArray(c + 2)[n + 1];
                        int y = m.GetByteArray(c + 3)[n] << 8 | m.GetByteArray(c + 3)[n + 1];
                        //total = 100 - ((Variables.worldHeight - y + Variables.worldWidth - x) / 100) * 10;
                        //DeserializeBar.Value = total;
                        Variables.block[x, y].BlockID = bid;
                    }
                    c += 4;
                }
                else
                {
                    break;
                }
            }

Anch

Processor · 2015-03-07 00:07:11

Your problem is that it doesn't handle special blocks like portals, coindoors, signs, labels, world portals, music blocks, rotatables, hazards, switches and so on... You would need to write special handlers for each of those block types.

Can we stop writing new world deserializers?

http://pastebin.com/9uFrYtYp
https://github.com/Yonom/CupCake/blob/m … ice.cs#L57
https://github.com/Yonom/BotBits/blob/m … ils.cs#L14
https://github.com/ThyChief/Fluid/blob/ … ld.cs#L693
https://github.com/Seist/Skylight/blob/ … ls.cs#L343

Psychocrysma, realmaster42, Anch

Lionhart · 2015-03-07 06:29:57

Processor wrote:

Can we stop writing new world deserializers?

Never!

public void BeatTheDeadHorse(Message stick) { ...

Also, I like the complete lack of comments and strange variable names such as "c" and "Variables".

Psychocrysma, Anch

Zumza · 2015-03-07 08:25:38

Everybody likes to make new Deserialisations methods.
http://pastebin.com/J6hVDect
http://pastebin.com/w7U9nNMf

Anch

realmaster42 · 2015-03-07 13:43:47

Processor wrote:

Your problem is that it doesn't handle special blocks like portals, coindoors, signs, labels, world portals, music blocks, rotatables, hazards, switches and so on... You would need to write special handlers for each of those block types.
Can we stop writing new world deserializers?
http://pastebin.com/9uFrYtYp
https://github.com/Yonom/CupCake/blob/m … ice.cs#L57
https://github.com/Yonom/BotBits/blob/m … ils.cs#L14
https://github.com/ThyChief/Fluid/blob/ … ld.cs#L693
https://github.com/Seist/Skylight/blob/ … ls.cs#L343

'Handle special blocks', does now, but doesn't get all block info when joining world yet... just after placing

Anch

stilltoolazytomakeanacc · 2015-03-14 21:42:03

Let's just keep making more deserializers.
In my defense, I made mine before y'all came out distributing yer own.
So there.

The real winner is to make one that doesn't break down when new specials are made.

That way bots can last longer.

And then when NVD decides to reorder existing messages, thereby breaking off reverse-compatibility with old bots, someone knock sense into 'em

realmaster42, Anch, Processor

lrussell · 2015-03-14 22:29:14

stilltoolazytomakeanacc wrote:

Let's just keep making more deserializers.
In my defense, I made mine before y'all came out distributing yer own.
So there.
The real winner is to make one that doesn't break down when new specials are made.
That way bots can last longer.
And then when NVD decides to reorder existing messages, thereby breaking off reverse-compatibility with old bots, someone knock sense into 'em

The real winner is when someone makes a proper auto-updater, then it doesn't matter if something breaks or not!

Psychocrysma, Anch

Processor · 2015-03-19 17:28:23

lrussell wrote:

The real winner is when someone makes a proper auto-updater, then it doesn't matter if something breaks or not!

Nah

stilltoolazytomakeanacc wrote:

The real winner is to make one that doesn't break down when new specials are made.

I win.

Anch

Official Everybody Edits Forums

#1 2015-03-06 22:27:57

[World Deserializer] Halp

#2 2015-03-07 00:07:11, last edited by Processor (2015-03-07 00:07:43)

Re: [World Deserializer] Halp

#3 2015-03-07 06:29:57, last edited by Lionhart (2015-03-07 06:33:32)

Re: [World Deserializer] Halp

#4 2015-03-07 08:25:38

Re: [World Deserializer] Halp

#5 2015-03-07 13:43:47

Re: [World Deserializer] Halp

#6 2015-03-14 21:42:03

Re: [World Deserializer] Halp

#7 2015-03-14 22:29:14

Re: [World Deserializer] Halp

#8 2015-03-19 17:28:23

Re: [World Deserializer] Halp

Board footer