Bot Disconnects after X Amount of Blocks Placed

AK712 · 2015-11-05 04:07:41

Hello,

This problem has halted development on a few of my bots and I need to know how to fix it. No matter what level my bot is in, it always disconnects after it draws X amount of blocks. No matter what I do, it's always the same... Can someone help? I have no clue why it's doing this... Is it something that was built into EE?

hummerz5 · 2015-11-05 04:42:06

sounds like you need a thread

[insert oprah 'you get a bees/suit/whatever' image, but sub it "thread"]

Xfrogman43 · 2015-11-05 04:46:35

hummerz5 wrote:

[insert oprah 'you get a bees/suit/whatever' image, but sub it "thread"]

Couldn't have just typed:
"You get a thread! And you get a thread!..."?
Thread.Sleep(10-20); is best.

Zumza · 2015-11-05 12:56:21

This reminds me of this http://forums.everybodyedits.com/viewtopic.php?id=30179

den3107 · 2015-11-05 13:12:52

Ak, perhaps post the code snippet that places the blocks?

Tomahawk · 2015-11-05 18:36:09

Give us some code and tell us how many blocks it sends before disconnecting; we're not mind readers.

The most likely problem is that you have no delay between each block that you send. EE will disconnect a bot that spams blocks too quickly, as the bot could lag or crash the room.
EE also blocks some packets if a bunch of them are sent too quickly (but not quickly enough for the bot to be kicked), which is why for instance a delay of 7ms will leave gaps in a line of blocks sent.

Xfrogman43 wrote:

Thread.Sleep(10-20); is best.

AK712 · 2015-11-05 22:23:08

for (int i = 0; i < mapsizex; i++)
                    {
                        for (int j = 0; j < mapsizey; j++)
                        {
                            connection.Send(worldKey, 0, i, j, fgarray[j, i]);
                            System.Threading.Thread.Sleep(8);
                            connection.Send(worldKey, 1, i, j, bgarray[j, i]);
                            System.Threading.Thread.Sleep(8);
                        }
                    }

So... It disconnects after about 1000 blocks. I should probably have it System.Threading.Thread.Sleep(100); after every row then... But the problem then would be the sheer amount of time it takes to draw :c

Tomahawk · 2015-11-05 22:29:26

Have you tried increasing the delay to about 15ms to see if it still disconnects?

If you add System.Threading to your list of usings, you only have to write Thread.Sleep(8);
Likewise, renaming your connection to "con" saves a surprising amount of time in the long run, even with intellisense.

den3107 · 2015-11-05 22:48:07

The minimum delay is 10, if I'm right it's something specified by Player.IO itself, and not necessarily by Everybody Edits.

Tomahawk wrote:

Likewise, renaming your connection to "con" saves a surprising amount of time in the long run, even with intellisense.

I beg to differ.

Tomahawk · 2015-11-05 23:14:19

den3107 wrote:

I beg to differ.

How about disagreeing with things that actually matter?

Tako

AK712 · 2015-11-05 23:23:05

Changing sleep time to 15 and adding a sleep time of 1000 after every row still disconnected the bot. Also, the amount of blocks it disconnected at was ~7850.

By this time it's drawing so absurdly slow... it's almost not worth it.

hummerz5 · 2015-11-05 23:43:10

Oh, go ahead and ignore my assistance
no problem
really
I'm not upset
serious. It's totally OK you folks... insert sarcastic retort here... not so much of a rejoinder, though.

den3107 · 2015-11-06 00:43:44

Tomahawk wrote:

den3107 wrote:
I beg to differ.
How about disagreeing with things that actually matter?

About that using the name con would be better.

hummerz5 wrote:

Oh, go ahead and ignore my assistance
no problem
really
I'm not upset
serious. It's totally OK you folks... insert sarcastic retort here... not so much of a rejoinder, though.

Not using a thread won't get you kicked out of the room.

AK712 · 2015-11-16 05:43:38

Two threads and two different bots placing blocks at the same time... bot users disconnect at the exact same time at the exact same number of blocks. Now I know there's something wrong with the game and not with my bots.

Looks like all my bots just went down the tubes ;-;

capasha · 2015-11-16 08:46:40

It's your connection. I have no problem in placing blocks. And I don't even get disconnected.
If I use EEArtist and get disconnected the bot will automatic upload the rest that it missed after the disconnect.
Maybe you should do something like that?

Processor · 2015-11-16 12:43:30

I bet it has something to do with you blocking the main connection thread, which causes it's internal buffer to overload. I just decompiled to check the source code of PlayerIOClient and saw that a buffer overload will indeed automatically disconnect your connection (there are 7200+ "b" messages waiting in line to be received). How confusing!

I assume that you are using .NET 4.0 or better. Run your blocking code in a worker thread then:

Task.Factory.StartNew(() => {
    // Put your for loop here
}, TaskCreationOptions.LongRunning);

I hope this helps.

ewoke, Hexagon

hummerz5 · 2015-11-16 14:43:55

but we said it wasn't the thread, so no

Processor · 2015-11-16 15:15:26

hummerz5 wrote:

but we said it wasn't the thread, so no

Where?

@AK712 Could you provide us an MCVE? (http://stackoverflow.com/help/mcve)

hummerz5 · 2015-11-17 03:57:38

Processor wrote:

hummerz5 wrote:
but we said it wasn't the thread, so no
Where?
@AK712 Could you provide us an MCVE? (http://stackoverflow.com/help/mcve)

hummerz5 wrote:

sounds like you need a thread

den3107 wrote:

hummerz5 wrote:
Oh, go ahead and ignore my assistance
no problem
really
I'm not upset
serious. It's totally OK you folks... insert sarcastic retort here... not so much of a rejoinder, though.
Not using a thread won't get you kicked out of the room.

Processor · 2015-11-17 13:29:41

I've provided a fairly technical explanation why in this case a thread might be required. I don't see why you would assume that den3107's statement is superior to mine.

hummerz5 · 2015-11-17 14:44:15

I outlined how I had the same idea and was rejected. It seems my sarcasm wasn't properly conveyed.

Tomahawk · 2015-11-17 19:33:41

Let's assume that PlayerIO and EE are not the issue, because no other coders have had this problem recently. We can then say that the error's in your code, AK.

So post more of it. The whole method that's writing the blocks (or the code around it if it's not in a method) and where it's called, as well as your connection code - in case you're screwing something up there.

It's a bit pointless to argue about the reason if there's not enough code provided; you make too many assumptions.

AK712 · 2015-11-24 00:49:25

using System;
using System.IO;
using System.Diagnostics;
using System.Threading;
using System.Linq;
using System.Collections.Generic;
using System.Windows.Forms;
using PlayerIOClient;

namespace WindowsFormsApplication1
{
    public partial class Form1 : Form
    {
        static Dictionary<int, userdata> users = new Dictionary<int, userdata>();
        public static int[,] fgarray = new int[300, 300];
        public static int[,] bgarray = new int[300, 300];
        public static int mapsizex = 300;
        public static int mapsizey = 300;
        public static Client client;
        public static Connection connection;
        public static bool connected = false;
        public static string worldKey;
        public bool hasaccess;
        static string derot(string arg1)
        {
            int num = 0;
            string str = "";
            for (int i = 0; i < arg1.Length; i++)
            {
                num = arg1[i];
                if ((num >= 0x61) && (num <= 0x7a))
                {
                    if (num > 0x6d) num -= 13;
                    else num += 13;
                }
                else if ((num >= 0x41) && (num <= 90))
                {
                    if (num > 0x4d) num -= 13;
                    else num += 13;
                }
                str = str + ((char)num);
            }
            return str;
        }
        public Form1()
        {
            InitializeComponent();
        }
        private void button1_Click(object sender, EventArgs e)
        {
            client = PlayerIO.QuickConnect.SimpleConnect("everybody-edits-su9rn58o40itdbnw69plyw", textBox1.Text, textBox2.Text);
            connection = client.Multiplayer.CreateJoinRoom("PWUjj3nEicb0I", "public", true, new Dictionary<string, string>(), new Dictionary<string, string>());
            connection.OnMessage += new MessageReceivedEventHandler(this.onMessage);
            connection.Send("init");
        }
        private void button3_Click(object sender, EventArgs e)
        {
            client = PlayerIO.QuickConnect.KongregateConnect("everybody-edits-su9rn58o40itdbnw69plyw", textBox1.Text, textBox2.Text);
            connection = client.Multiplayer.CreateJoinRoom(textBox3.Text, "public", true, new Dictionary<string, string>(), new Dictionary<string, string>());
            connection.OnMessage += new MessageReceivedEventHandler(this.onMessage);
            connection.Send("init");
        }
        public void readFGFile(string file)
        {
            StreamReader sr = new StreamReader(file);
            String line;
            try
            {
                line = sr.ReadLine();
                while (line != null)
                {
                    int[] thisarray = line.Split(',').Select(n => Convert.ToInt32(n)).ToArray();
                    for (int i = 0; i < mapsizey; i++)
                    {
                        for (int j = 0; j < mapsizex; j++)
                        {
                            fgarray[i, j] = thisarray[(i * mapsizex) + j];
                        }
                    }
                    line = sr.ReadLine();
                }
            }
            finally
            {
                sr.Close();
            }
        }
        public void readBGFile(string file)
        {
            StreamReader sr = new StreamReader(file);
            String line;
            try
            {
                line = sr.ReadLine();
                while (line != null)
                {
                    int[] thisarray = line.Split(',').Select(n => Convert.ToInt32(n)).ToArray();
                    for (int i = 0; i < mapsizey; i++)
                    {
                        for (int j = 0; j < mapsizex; j++)
                        {
                            bgarray[i, j] = thisarray[(i * mapsizex) + j];
                        }
                    }
                    line = sr.ReadLine();
                }
            }
            finally
            {
                sr.Close();
            }
        }
        public void onMessage(object sender, PlayerIOClient.Message m)
        {
            if (m.Type == "init")
            {
                fgarray = new int[300, 300];
                bgarray = new int[300, 300];
                for (int x = 0; x < 300; x++)
                {
                    for (int y = 0; y < 300; y++)
                    {
                        fgarray[x, y] = 0;
                        bgarray[x, y] = 0;
                    }
                }
                worldKey = derot(m.GetString(5));
                connection.Send("init2");
                System.Threading.Thread.Sleep(20);
            }
            if (m.Type == "add")
            {
                users.Add(m.GetInt(0), new userdata() { username = m.GetString(1)});
                System.Threading.Thread.Sleep(20);
            }
            if (m.Type == "b")
            {
                if (m.GetInt(0) == 0)
                {
                    fgarray[m.GetInt(2), m.GetInt(1)] = m.GetInt(3);
                }
                else if (m.GetInt(0) == 1)
                {
                    bgarray[m.GetInt(2), m.GetInt(1)] = m.GetInt(3);
                }
            }
            if (m.Type == "say")
            {
                string s = m.GetString(1);
                if (s.StartsWith("!mapsizex ") && users[m.GetInt(0)].username == "ak712")
                {
                    mapsizex = Convert.ToInt32(s.Substring(10));
                    fgarray = new int[mapsizey, mapsizex];
                    bgarray = new int[mapsizey, mapsizex];
                    for (int x = 0; x < mapsizex; x++)
                    {
                        for (int y = 0; y < mapsizey; y++)
                        {
                            fgarray[y, x] = 0;
                            bgarray[y, x] = 0;
                        }
                    }
                }
                if (s.StartsWith("!mapsizey ") && users[m.GetInt(0)].username == "ak712")
                {
                    mapsizey = Convert.ToInt32(s.Substring(10));
                    fgarray = new int[mapsizey, mapsizex];
                    bgarray = new int[mapsizey, mapsizex];
                    for (int x = 0; x < mapsizex - 1; x++)
                    {
                        for (int y = 0; y < mapsizey - 1; y++)
                        {
                            fgarray[y, x] = 0;
                            bgarray[y, x] = 0;
                        }
                    }
                }
                if (s.StartsWith("!createmap") && users[m.GetInt(0)].username == "ak712")
                {
                    mapsizex = 94;
                    mapsizey = 226;
                    fgarray = new int[mapsizey, mapsizex];
                    bgarray = new int[mapsizey, mapsizex];
                    readFGFile("Example.txt");
                    readBGFile("Example2.txt");
                    for (int i = 0; i < mapsizex; i++)
                    {
                        for (int j = 0; j < mapsizey; j++)
                        {
                            if (fgarray[j, i] > 0)
                            {
                                connection.Send(worldKey, 0, i, j, fgarray[j, i]);
                                System.Threading.Thread.Sleep(15);
                            }
                            if (bgarray[j, i] > 0)
                            {
                                connection.Send(worldKey, 1, i, j, bgarray[j, i]);
                                System.Threading.Thread.Sleep(15);
                            }
                        }
                        System.Threading.Thread.Sleep(1);
                    }
                }
            }
        }
        class userdata
        {
            public string username { get; set; }
        }
    }
}

Tomahawk · 2015-11-24 22:40:11

Hm.

While there's a number of things in your code which could be corrected or simplified, there's nothing there that would make your bot disconnect while sending blocks.

Have you tested if the bot disconnects while just sitting in a world, or while sending lots of some other message? The problem might not be specifically to do with block sending; for all we know your internet connection could be glitching every few minutes.

Processor · 2015-11-24 22:48:09

You should still try my suggestion.

Official Everybody Edits Forums

#1 2015-11-05 04:07:41

Bot Disconnects after X Amount of Blocks Placed

#2 2015-11-05 04:42:06

Re: Bot Disconnects after X Amount of Blocks Placed

#3 2015-11-05 04:46:35

Re: Bot Disconnects after X Amount of Blocks Placed

#4 2015-11-05 12:56:21

Re: Bot Disconnects after X Amount of Blocks Placed

#5 2015-11-05 13:12:52

Re: Bot Disconnects after X Amount of Blocks Placed

#6 2015-11-05 18:36:09

Re: Bot Disconnects after X Amount of Blocks Placed

#7 2015-11-05 22:23:08

Re: Bot Disconnects after X Amount of Blocks Placed

#8 2015-11-05 22:29:26, last edited by Tomahawk (2015-11-05 22:36:09)

Re: Bot Disconnects after X Amount of Blocks Placed

#9 2015-11-05 22:48:07

Re: Bot Disconnects after X Amount of Blocks Placed

#10 2015-11-05 23:14:19

Re: Bot Disconnects after X Amount of Blocks Placed

#11 2015-11-05 23:23:05

Re: Bot Disconnects after X Amount of Blocks Placed

#12 2015-11-05 23:43:10

Re: Bot Disconnects after X Amount of Blocks Placed

#13 2015-11-06 00:43:44

Re: Bot Disconnects after X Amount of Blocks Placed

#14 2015-11-16 05:43:38

Re: Bot Disconnects after X Amount of Blocks Placed

#15 2015-11-16 08:46:40

Re: Bot Disconnects after X Amount of Blocks Placed

#16 2015-11-16 12:43:30, last edited by Processor (2015-11-24 22:47:29)

Re: Bot Disconnects after X Amount of Blocks Placed

#17 2015-11-16 14:43:55

Re: Bot Disconnects after X Amount of Blocks Placed

#18 2015-11-16 15:15:26

Re: Bot Disconnects after X Amount of Blocks Placed

#19 2015-11-17 03:57:38, last edited by hummerz5 (2015-11-17 03:58:06)

Re: Bot Disconnects after X Amount of Blocks Placed

#20 2015-11-17 13:29:41

Re: Bot Disconnects after X Amount of Blocks Placed

#21 2015-11-17 14:44:15

Re: Bot Disconnects after X Amount of Blocks Placed

#22 2015-11-17 19:33:41, last edited by Tomahawk (2015-11-17 19:34:15)

Re: Bot Disconnects after X Amount of Blocks Placed

#23 2015-11-24 00:49:25

Re: Bot Disconnects after X Amount of Blocks Placed

#24 2015-11-24 22:40:11, last edited by Tomahawk (2015-11-24 22:41:24)

Re: Bot Disconnects after X Amount of Blocks Placed

#25 2015-11-24 22:48:09

Re: Bot Disconnects after X Amount of Blocks Placed

Board footer